[php-wasm-logger] Remove unnecessary @php-wasm/node-polyfills dependency#3471
Closed
[php-wasm-logger] Remove unnecessary @php-wasm/node-polyfills dependency#3471
@php-wasm/node-polyfills dependency#3471Conversation
mho22
added
[Package][@php-wasm] Logger
dependencies
Member
|
@mho22 uh-oh, what happened here? Not fit to merge? Follow up PR? Best to leave a comment :) |
Member
|
Closed in favor of #3476 |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
The
@php-wasm/loggerpackage imports@php-wasm/node-polyfillssolely for theCustomEventpolyfill (used inlog-event.tsandcollect-php-logs.ts). However,CustomEventhas been a native global since Node.js v19, and this project requires Node.js >= 20.10.0. The import is dead weight — it pulls in unnecessary polyfills (File, Blob, etc.) that the logger never uses.Implementation details
@php-wasm/node-polyfillsside-effect import frompackages/php-wasm/logger/src/index.ts@php-wasm/node-polyfillsdependency in the dist package.json is auto-generated during build and will be dropped automatically.Testing Instructions (or ideally a Blueprint)
CI